search

adrium / easypass

*️⃣ Manage your passwords easily and securely, via browser extension for Firefox, Chrome, Opera or Edge
https://chrome.google.com/webstore/detail/adrium-easy-pass/ebigikdfolbipomeaknpooibomohhhhk
Mozilla Public License 2.0
0 stars 1 forks source link

Manifest v3 #1

Open adrium opened 10 months ago

adrium commented 10 months ago

Manifest v3 should be supported.

adrium commented 10 months ago

Hi @palant, I am interested in keeping the AEP/PFP legacy version alive. I love not having a database. I had a glimpse at your manifest-v3 branch, but I am not sure which changes are actually required to make the extension compatible with MV3. Furthermore, I saw that Firefox can keep an MV2 version.

Would you guide me in the right direction to make the necessary adjustments?

Thanks and merry Christmas

palant commented 10 months ago

Manifest V3 support is not a trivial task, not like changing a few names here and there. While I did a bit of general refactoring on the manifest-v3 branch, most of the changes were necessary. The code restructuring was largely required because the persistent background page is no more and it’s a background worker instead which could go away any time. This got particularly messy around remembering the master password for example – global variables had to be replaced by storage.session API. Maybe all of this could be done with somewhat less invasive changes, but that won’t be simple either.

Having gone through the changes, maybe the internal communication changes (getPort & Co.) weren’t strictly required here. But I honestly don’t remember, and I wouldn’t be surprised if the code structure changed enough that these were required after all.

adrium commented 10 months ago

Thanks for your answer @palant - that sounds like a difficult endeavour. Seems like the architecture needs to be changed considerably. I will probably have time to start working on it in April.