Added "from_r0" to Burkert potential

adrn / gala

Galactic and gravitational dynamics in Python

http://gala.adrian.pw

MIT License

130 stars 56 forks source link

Added "from_r0" to Burkert potential #370

Closed HSouch closed 2 months ago

HSouch commented 7 months ago

Added a method to generate the Burkert potential from just the r0

This is standard practice, as it is ultimately a 1-parameter potential. The relationship between density and core radius is described in Equations 4 and 5 of Mori & Burkert 2000.

Checklist

[x] Did you add tests?
[x] Did you add documentation for your changes?
[ ] Did you reference any relevant issues?
[x] Did you add a changelog entry? (see CHANGES.rst)
[x] Are the CI tests passing?
[x] Is the milestone set?

adrn commented 2 months ago

Sorry for the long delay! I rebased your PR, so pull locally before you make any additional changes. I left one suggested change and one comment on the implementation. Thanks!

adrn commented 2 months ago

Thanks @HSouch!