search

adrn / thejoker

A custom Monte Carlo sampler for the (gravitational) two-body problem
MIT License
30 stars 8 forks source link

Rename t0 -> t_ref where relevant #109

Closed adrn closed 3 years ago

adrn commented 3 years ago

This PR resolves a longstanding "bug" in naming: I use the name t0 loosely to refer to both a reference epoch and the time at which an orbit has 0 phase. This PR renames t0 to t_ref in places where it is actually a reference time. It also adds functionality to compute the time of zero phase for a sample, given that we actually sample in "phase at reference time".

codecov-io commented 3 years ago

Codecov Report

Merging #109 (1e957b8) into main (ab0e0ea) will increase coverage by 0.00%. The diff coverage is 83.19%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #109   +/-   ##
=======================================
  Coverage   77.56%   77.57%           
=======================================
  Files          14       15    +1     
  Lines        1520     1574   +54     
=======================================
+ Hits         1179     1221   +42     
- Misses        341      353   +12
Impacted Files Coverage Δ
thejoker/data_helpers.py 93.33% <ø> (ø)
thejoker/thejoker.py 46.25% <50.00%> (ø)
thejoker/plot.py 85.51% <65.21%> (-2.55%) :arrow_down:
thejoker/multiproc_helpers.py 85.43% <71.42%> (+0.29%) :arrow_up:
thejoker/samples.py 82.47% <76.47%> (-1.41%) :arrow_down:
thejoker/prior.py 88.29% <93.33%> (+0.06%) :arrow_up:
thejoker/data.py 85.50% <100.00%> (+0.76%) :arrow_up:
thejoker/exceptions.py 100.00% <100.00%> (ø)
thejoker/likelihood_helpers.py 23.59% <100.00%> (ø)
thejoker/utils.py 90.51% <100.00%> (+0.21%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aab7d6a...1e957b8. Read the comment docs.