last batch of changes as disscussed in the last meeting

[seasidesparrow]

Are the publisher-source scores being assigned somewhere, or does that happen in another service? From CSG email:

spires                  1.05
publisher              1.1
author-submitted 1.2
ads-curated         1.3

[golnazads]

They are in the oracle database.

On Mon, May 8, 2023 at 3:58 PM Matthew Templeton @.***> wrote:

Are the publisher-source scores being assigned somewhere, or does that happen in another service? From CSG email:

spires 1.05 publisher 1.1 author-submitted 1.2 ads-curated 1.3

— Reply to this email directly, view it on GitHub https://github.com/adsabs/ADSDocMatchPipeline/pull/16#issuecomment-1538962640, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3M4CGOWOHHP423IXYZXJ3XFFF77ANCNFSM6AAAAAAXZD7YOI . You are receiving this because you authored the thread.Message ID: @.***>

[golnazads]

yes.

On Wed, May 10, 2023 at 10:59 AM Matthew Templeton @.***> wrote:

@.**** commented on this pull request.

In adsdocmatch/oracle_util.py https://github.com/adsabs/ADSDocMatchPipeline/pull/16#discussion_r1190040670 :

class OracleUtil():

• COLLABORATION_PAT = re.compile(r"(?P[([][A-Za-z\s-\/]+\s[Cc]ollaboration[s]?\s[A-Z.]*[\s.,)]]+)")
• COLLABORATION_PAT = re.compile(r"(?P[([][A-Za-z\s-\/]+\s[Cc]ollaboration[s]?\s[A-Z.]*)(?:[\s.,;)]]+|$)")

Is there a test for this regex?

— Reply to this email directly, view it on GitHub https://github.com/adsabs/ADSDocMatchPipeline/pull/16#pullrequestreview-1420846025, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG3M4CFOVZHLMXIKVGNZWP3XFOULPANCNFSM6AAAAAAXZD7YOI . You are receiving this because you authored the thread.Message ID: @.***>