search

adsabs / ADSImportPipeline

Data ingest pipeline for ADS classic->ADS+
GNU General Public License v3.0
1 stars 12 forks source link

Sql celery ingest fixes #138

Closed spacemansteve closed 7 years ago

spacemansteve commented 7 years ago

Includes Celery based pipeline, sql based adsdata and fixes to the pipeline.

spacemansteve commented 7 years ago

Currently only one test is failing: test_app.py/TestWorkers.test_task_merge_metadata

spacemansteve commented 7 years ago

I am confused why I had to change the pubnote test data for one bibcode (https://github.com/spacemansteve/ADSimportpipeline/blob/sqlCeleryIngestFixes/tests/stubdata/ADSRecords/2015ApJ...815..133S#L716) but not another (https://github.com/spacemansteve/ADSimportpipeline/blob/sqlCeleryIngestFixes/tests/stubdata/ADSRecords/2017FrPhy..12l0504C#L512). I thought the first pubnote was incorrectly formed and changed it (https://github.com/spacemansteve/ADSimportpipeline/commit/f539e39acc7fcb2476d92ed9852fb5888fe1c7bb#diff-28c31b4299319c6b60a83c8dee335c79L715) so tests would pass. I didn't have to change the second one.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.6%) to 71.995% when pulling bb2650bd3d1cd2b1f147cfe6a66f9d7bfe5391d3 on spacemansteve:sqlCeleryIngestFixes into 65f3c0c81fb7d1820afcd0a006a7e9ee06ba9c79 on adsabs:master.