Using a library instead of repeating the code all over

adsabs / ADSImportPipeline

Data ingest pipeline for ADS classic->ADS+

GNU General Public License v3.0

1 stars 12 forks source link

Using a library instead of repeating the code all over #143

Closed romanchyla closed 7 years ago

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 71.473% when pulling eea4f87be00399b53d7b55d05b8661b356da6a41 on romanchyla:dry into 188324f24dbc63e7e265e7ff08bb9c241f38217c on adsabs:master.

coveralls commented 7 years ago

Coverage decreased (-2.4%) to 69.682% when pulling 7bc0be8280b02987183a922a3aff3fd43f5def5e on romanchyla:dry into 188324f24dbc63e7e265e7ff08bb9c241f38217c on adsabs:master.

romanchyla commented 7 years ago

@marblestation or @spacemansteve can you please review/merge this PR? The coverage decreased 2% - which is counterintuitive (cause I removed code), but will take a note on pushing for more unittests in the next PR. Thanks

coveralls commented 7 years ago

Coverage decreased (-2.4%) to 69.682% when pulling 57dded827fb02199b9408f456647a2a8359f30fb on romanchyla:dry into 188324f24dbc63e7e265e7ff08bb9c241f38217c on adsabs:master.

coveralls commented 7 years ago

Coverage decreased (-2.4%) to 69.682% when pulling 57dded827fb02199b9408f456647a2a8359f30fb on romanchyla:dry into 188324f24dbc63e7e265e7ff08bb9c241f38217c on adsabs:master.

coveralls commented 7 years ago

Coverage decreased (-2.3%) to 69.701% when pulling 530de8cff7437ab792b17c0304714e9090669026 on romanchyla:dry into 188324f24dbc63e7e265e7ff08bb9c241f38217c on adsabs:master.