search

adsabs / ADSImportPipeline

Data ingest pipeline for ADS classic->ADS+
GNU General Public License v3.0
1 stars 12 forks source link

define author_type in once place only. #210

Open golnazads opened 5 years ago

golnazads commented 5 years ago

Per Alberto's suggestion Define author types globally author_type = ['regular', 'collaboration'] then use it in the several places that needs to be used https://github.com/adsabs/ADSImportPipeline/blob/master/aip/classic/solr_adapter.py#L124 https://github.com/adsabs/ADSImportPipeline/blob/master/aip/classic/solr_adapter.py#L152 https://github.com/adsabs/ADSImportPipeline/blob/master/aip/classic/solr_adapter.py#L158 https://github.com/adsabs/ADSImportPipeline/blob/master/aip/classic/solr_adapter.py#L165 https://github.com/adsabs/ADSImportPipeline/blob/master/aip/classic/solr_adapter.py#L186 https://github.com/adsabs/ADSImportPipeline/blob/master/aip/classic/solr_adapter.py#L195

golnazads commented 5 years ago

this is done. Steve feel free to close it.