search

adsabs / ADSImportPipeline

Data ingest pipeline for ADS classic->ADS+
GNU General Public License v3.0
1 stars 12 forks source link

in continuation with issue 217, #220

Closed golnazads closed 5 years ago

golnazads commented 5 years ago

as suggested by Alberto added identifier to enforcer https://github.com/adsabs/ADSImportPipeline/issues/217#issuecomment-449467508

golnazads commented 5 years ago

good morning

Added identifier to 2009AAS...21320006C test structure to have it pass the enforcer test. It was cumbersome to read the structure, so I just located the alternate and added identifier right after it. If you think the data is outdated, if you let me know now to generate the test structure, I shall grab current record from solr to update the test.

Regarding the test for ascl, it was added along with variation of arXiv id,, just to be on the safe side, and eprint test, in the previous commit: https://github.com/adsabs/ADSImportPipeline/commit/cb2bca67c3cc61aa14b3240bc9d82ed6e84dfba4#diff-83a9a33d1ee84cc60e38d39abb6ea833

golnaz

On Fri, Dec 21, 2018 at 3:01 PM Alberto Accomazzi notifications@github.com wrote:

@aaccomazzi commented on this pull request.

The test for 2009AAS...21320006C does not look right to me -- no element should get created by adspy/ADSCachedExports, because bibcodes go in metadata/general/bibcode, not metadata/relations/identifiers. I suggest having a test for 2018ascl.soft12002J, which should generate an identifier of ascl:1812.002

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/adsabs/ADSImportPipeline/pull/220#pullrequestreview-187522102, or mute the thread https://github.com/notifications/unsubscribe-auth/AbbOCBROeaqRho2tZ1O9cXaUS_LOpAANks5u7T4JgaJpZM4Zep4s .

aaccomazzi commented 5 years ago

ok, now I get it -- didn't see that it was mocked data.