search

adsabs / ADSIngestParser

Curation parser library
MIT License
0 stars 7 forks source link

Collab #119

Closed mugdhapolimera closed 3 months ago

mugdhapolimera commented 3 months ago

I noticed that some affiliation related assertion failed. This is not for any new file that I uploaded. @seasidesparrow is this related to one of your recent PRs?

seasidesparrow commented 3 months ago

I noticed that some affiliation related assertion failed. This is not for any new file that I uploaded. @seasidesparrow is this related to one of your recent PRs?

I'll check your git log, but this commit should be included in your branch if it is not: https://github.com/adsabs/ADSIngestParser/commit/3281e2dd3715f2240bd0f41159ef3003abdbd4b0

seasidesparrow commented 3 months ago

It looks like your original test output was based on the old version of affPubID, but this field is now an array of AffID objects. However, the parser isn't outputting what I would expect -- it's assigning all the pubIDs for all of an authors institution to each institution. For example, 000000041936754X and grid.38142.3c are just for Harvard University, not for all three institutions.

mugdhapolimera commented 3 months ago

@seasidesparrow I didn't change anything related to the affid stuff in this PR. Could it be a bug from the other commit?