search

adsabs / ADSIngestParser

Curation parser library
MIT License
0 stars 7 forks source link

Datacite fix #38

Closed seasidesparrow closed 1 year ago

seasidesparrow commented 1 year ago

Fixes cases where tags with missing attributes were causing exceptions while parsing valid datacite records.

seasidesparrow commented 1 year ago

Re: linter, I've seen multiple SE & github threads where people suggest bumping isort to =>5.12.0, but it still failed when I tried it. Possibly related to pre-commit? Or macOS weirdness? Or codecov. Or a day ending in 'y'...

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 :tada:

Comparison is base (b1b1890) 86.62% compared to head (98dd691) 86.68%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #38 +/- ## ========================================== + Coverage 86.62% 86.68% +0.05% ========================================== Files 20 20 Lines 2094 2095 +1 ========================================== + Hits 1814 1816 +2 + Misses 280 279 -1 ``` | [Impacted Files](https://codecov.io/gh/adsabs/ADSIngestParser/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs) | Coverage Δ | | |---|---|---| | [tests/test\_datacite.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9kYXRhY2l0ZS5weQ==) | `90.90% <ø> (ø)` | | | [adsingestp/parsers/datacite.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2RhdGFjaXRlLnB5) | `89.08% <100.00%> (+0.64%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.