adsabs / ADSIngestParser

Curation parser library
MIT License
0 stars 7 forks source link

Adding "string-name" as a possible contrib name entity in JATS parser #39

Closed seasidesparrow closed 1 year ago

seasidesparrow commented 1 year ago

At least some JATS (PNAS, notably) may use a <"string-name"> tag for a contributor in place of <"name">. The included test file includes an interesting side case where there are a large number of otherContribs.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22 :tada:

Comparison is base (b1b1890) 86.62% compared to head (975cb6b) 86.85%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #39 +/- ## ========================================== + Coverage 86.62% 86.85% +0.22% ========================================== Files 20 20 Lines 2094 2100 +6 ========================================== + Hits 1814 1824 +10 + Misses 280 276 -4 ``` | [Impacted Files](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs) | Coverage Δ | | |---|---|---| | [adsingestp/parsers/base.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2Jhc2UucHk=) | `93.18% <ø> (ø)` | | | [tests/test\_arxiv.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9hcnhpdi5weQ==) | `94.73% <ø> (ø)` | | | [tests/test\_crossref.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9jcm9zc3JlZi5weQ==) | `93.93% <ø> (ø)` | | | [tests/test\_datacite.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9kYXRhY2l0ZS5weQ==) | `90.90% <ø> (ø)` | | | [tests/test\_elsevier.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9lbHNldmllci5weQ==) | `90.90% <ø> (ø)` | | | [tests/test\_jats.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9qYXRzLnB5) | `93.93% <ø> (ø)` | | | [tests/test\_wiley.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF93aWxleS5weQ==) | `91.17% <ø> (ø)` | | | [adsingestp/parsers/datacite.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2RhdGFjaXRlLnB5) | `89.08% <100.00%> (+0.64%)` | :arrow_up: | | [adsingestp/parsers/jats.py](https://codecov.io/gh/adsabs/ADSIngestParser/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2phdHMucHk=) | `86.82% <100.00%> (+0.60%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.