codecov-commenter
commented
1 year ago Codecov Report
Attention: 9 lines in your changes are missing coverage. Please review.
Comparison is base (
2da7ab6) 88.31% compared to head (d15e564) 88.40%. Report is 6 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #69 +/- ## ========================================== + Coverage 88.31% 88.40% +0.08% ========================================== Files 20 24 +4 Lines 2183 2492 +309 ========================================== + Hits 1928 2203 +275 - Misses 255 289 +34 ``` | [Files](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs) | Coverage Δ | | |---|---|---| | [tests/test\_parserfeedback.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9wYXJzZXJmZWVkYmFjay5weQ==) | `96.42% <96.42%> (ø)` | | | [adsingestp/parsers/adsfeedback.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2Fkc2ZlZWRiYWNrLnB5) | `85.45% <85.45%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/69/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
seasidesparrow
This looks good, just a minor change to the .init() and .parse() methods so that they can both load data (and default to None, so that it's optional for both), and add the test case with unicode we discussed in slack.