search

adsabs / ADSIngestParser

Curation parser library
MIT License
0 stars 7 forks source link

Fix: adds datacite tests for Zenodo records, moves _detag function fr… #75

Closed seasidesparrow closed 9 months ago

seasidesparrow commented 9 months ago

…om JATSParser to BaseBeautifulSoupParser and renames tagsets from JATS to HTML

modified:   adsingestp/parsers/base.py
modified:   adsingestp/parsers/datacite.py
modified:   adsingestp/parsers/jats.py
new file:   tests/stubdata/input/zenodo_test.xml
new file:   tests/stubdata/input/zenodo_test2.xml
new file:   tests/stubdata/input/zenodo_test3.xml
new file:   tests/stubdata/input/zenodo_test4.xml
modified:   tests/stubdata/output/datacite_schema3.1_example-full.json
modified:   tests/stubdata/output/datacite_schema4.1_example-full.json
modified:   tests/stubdata/output/datacite_schema4.1_example-software.json
modified:   tests/stubdata/output/datacite_schema4_example-habanero-pdsdataset.json
new file:   tests/stubdata/output/zenodo_test.json
new file:   tests/stubdata/output/zenodo_test2.json
new file:   tests/stubdata/output/zenodo_test3.json
new file:   tests/stubdata/output/zenodo_test4.json
modified:   tests/test_datacite.py
codecov-commenter commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (39ae85a) 88.54% compared to head (68ccd8b) 89.79%. Report is 32 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #75 +/- ## ========================================== + Coverage 88.54% 89.79% +1.25% ========================================== Files 24 25 +1 Lines 2496 2616 +120 ========================================== + Hits 2210 2349 +139 + Misses 286 267 -19 ``` | [Files](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs) | Coverage Δ | | |---|---|---| | [adsingestp/parsers/crossref.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2Nyb3NzcmVmLnB5) | `92.13% <100.00%> (+0.05%)` | :arrow_up: | | [tests/test\_base.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9iYXNlLnB5) | `100.00% <100.00%> (ø)` | | | [tests/test\_datacite.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9kYXRhY2l0ZS5weQ==) | `91.17% <100.00%> (+0.26%)` | :arrow_up: | | [tests/test\_jats.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-dGVzdHMvdGVzdF9qYXRzLnB5) | `95.06% <100.00%> (+0.12%)` | :arrow_up: | | [adsingestp/parsers/datacite.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2RhdGFjaXRlLnB5) | `91.44% <92.30%> (+2.61%)` | :arrow_up: | | [adsingestp/parsers/base.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2Jhc2UucHk=) | `93.49% <94.11%> (+0.16%)` | :arrow_up: | | [adsingestp/parsers/jats.py](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs#diff-YWRzaW5nZXN0cC9wYXJzZXJzL2phdHMucHk=) | `93.33% <96.49%> (+2.22%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/adsabs/ADSIngestParser/pull/75/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adsabs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seasidesparrow commented 9 months ago

Also adds OA/license capture to to Datacite parser