search

adsabs / ADSIngestParser

Curation parser library
MIT License
0 stars 7 forks source link

fix: copernicus electronic issn captured correctly #86

Closed seasidesparrow closed 6 months ago

seasidesparrow commented 6 months ago 
modified:   adsingestp/parsers/copernicus.py
modified:   tests/stubdata/output/copernicus_ESSD_essd-15-3075-2023.json
modified:   tests/stubdata/output/copernicus_GeChr_gchron-5-323-2023.json
modified:   tests/stubdata/output/copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
modified:   tests/stubdata/output/copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
modified:   tests/stubdata/output/copernicus_wes-8-1625-2023.json
modified:   tests/test_copernicus.py
modified:   tests/stubdata/output/Copernicus_ESSD_essd-15-3075-2023.json
modified:   tests/stubdata/output/Copernicus_GeChr_gchron-5-323-2023.json
modified:   tests/stubdata/output/Copernicus_ISPAn_isprs-annals-X-M-1-2023-237-2023.json
modified:   tests/stubdata/output/Copernicus_ISPAr_isprs-archives-XLVIII-M-2-2023-721-2023.json
codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0938a1c) 89.78% compared to head (74b2ef0) 89.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #86 +/- ## ======================================= Coverage 89.78% 89.78% ======================================= Files 25 25 Lines 2615 2615 ======================================= Hits 2348 2348 Misses 267 267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mugdhapolimera commented 6 months ago

Everything looks good! just one minor suggestion.