Added handling for simple-article

mugdhapolimera commented 6 months ago

P.S. : Also added some clean up statements for titles.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.29%. Comparing base (6473c3f) to head (61d5a70).

Files	Patch %	Lines
adsingestp/parsers/elsevier.py	86.66%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #93 +/- ## ========================================== + Coverage 89.99% 90.29% +0.30% ========================================== Files 25 25 Lines 2618 2627 +9 ========================================== + Hits 2356 2372 +16 + Misses 262 255 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seasidesparrow commented 6 months ago

I am considering revising slightly how we do this in light of the number of document types that Elsevier may provide in addition to ja:article and 'ja:simple-article`. Their schema document (https://supportcontent.elsevier.com/Support%20Hub/DaaS/36178_ConSyn_Schemas_Document.pdf) lists the following potential article types:

cja:converted-article
ja:article
ja:simple-article
ja:book-review
ja:exam
bk:book
bk:chapter
bk:simple-chapter
bk:examination
bk:fb-non-chapter
bk:glossary
bk:index
bk:introduction
bk:bibliography

We don't necessarily want all of these, but certainly a subset of them.

adsabs / ADSIngestParser

Added handling for simple-article #93

Codecov Report