adsabs / ADSPlanetaryNamesPipeline

Pipeline to identify planetary nomenclature in fulltext of ADS records
MIT License
0 stars 1 forks source link

Synonyms update #2

Open golnazads opened 6 days ago

golnazads commented 6 days ago

Conversation from the PR #1

adsplanetnamepipe/utils/common.py class Synonyms(object):

# generated 5/20/2022
synonym_list = {

Member @kelockhart kelockhart on Jul 25 How frequently do you see this being updated? If not very often, this is fine; otherwise consider moving to a config

Member Author @golnazads golnazads on Jul 26 Need to ask, I dont know the answer.

Update I asked Alberto about this, and he said that he talked to you (Kelly) and also Taylor. I brought up the same issue on the side of resolver service with Taylor. Over there, I am one step closer. There are files on the server that Edwin modifies on a regular basis. They are called source matchers. Reading and processing them takes some time, so I do that offline, create a serializable object, and then load that every time the service is deployed. I went through the motion, got files from the server, created a serializable object, uploaded it to GitHub, and asked Taylor to see if he could upload the serializable object to the pod without making a release. It was just before his vacation. He said he would think about it afterward. So, I think I should do the same thing here as well: make a serializable object and update it on a regular basis. I will make an issue out of this and wait to see if it works for the resolver. If it does, then I’ll proceed this way; otherwise, I’ll go with another approach.

@kelockhart @tjacovich @aaccomazzi

aaccomazzi commented 6 days ago

The synonym updates should be rare, since they concern only the solar system objects, which is a small and finite list. So I wouldn't sweat about automating the update, I would expect maybe a need for a once a year update at most.

For the source matchers we can expect weekly updates from the curators, so automating or streamlining that deployment is critical.