adsabs / ExpansionReporting

MIT License
0 stars 2 forks source link

Running completeness report generates exception resulting from dependency #25

Open ehenneken opened 1 month ago

ehenneken commented 1 month ago

Running python3 run.py --subject FULLTEXT --collection ES generates

Traceback (most recent call last):
  File "run.py", line 7, in <module>
    from xreport import tasks
  File "/app/xreport/tasks.py", line 5, in <module>
    import xreport.app as app_module
  File "/app/xreport/app.py", line 1, in <module>
    from adsputils import ADSCelery
  File "/proj/ads/ads/.local/lib/python3.8/site-packages/adsputils/__init__.py", line 32, in <module>
    from .serializer import register_args
  File "/proj/ads/ads/.local/lib/python3.8/site-packages/adsputils/serializer.py", line 2, in <module>
    from adsmsg.msg import Msg
  File "/proj/ads/ads/.local/lib/python3.8/site-packages/adsmsg/__init__.py", line 1, in <module>
    from .augmentrecord import AugmentAffiliationRequestRecord, \
  File "/proj/ads/ads/.local/lib/python3.8/site-packages/adsmsg/augmentrecord.py", line 1, in <module>
    from .msg import Msg
  File "/proj/ads/ads/.local/lib/python3.8/site-packages/adsmsg/msg.py", line 7, in <module>
    from .protobuf import status_pb2 as Status
  File "/proj/ads/ads/.local/lib/python3.8/site-packages/adsmsg/protobuf/status_pb2.py", line 22, in <module>
    create_key=_descriptor._internal_create_key,
AttributeError: module 'google.protobuf.descriptor' has no attribute '_internal_create_key'
seasidesparrow commented 1 month ago

Stackoverflow suggests protobuf package incompatibility: https://stackoverflow.com/questions/61922334/how-to-solve-attributeerror-module-google-protobuf-descriptor-has-no-attribu

ehenneken commented 1 month ago

@tjacovich will the exception shown above disappear with a newer version of adsputils? I have adsputils==1.2.8 in requirements.txt

tjacovich commented 1 month ago

@ehenneken I believe so. I think grabbing anything with adsmsg>=1.3.6 should do it, so anything adsputils>=1.5.2.