search

adsabs / adsws

ADS web services
Other
2 stars 14 forks source link

Keep the clients around for 3 months; and add them a token if expired #148

Closed romanchyla closed 5 years ago

romanchyla commented 6 years ago

@marblestation is this what you had in mind to preserve clients (for tracking)?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.01%) to 82.805% when pulling af29a3135f78ac91bbeafc3f954ce3f480459cf9 on romanchyla:make-temp-token into 7e47c4b621039fff62efb506ca7d46d5ba85ea21 on adsabs:master.

marblestation commented 6 years ago

@romanchyla The requirement was 1 year (but we can revisit it with the rest). What would be the disadvantage of creating tokens with longer expiration dates instead of creating new tokens from the cleaning script if they have expired as this PR does?