search

adsabs / adsws

ADS web services
Other
2 stars 15 forks source link

Including extensions should not set routes #28

Closed vsudilov closed 9 years ago

vsudilov commented 9 years ago

Routes like

/v1/services/oauth/authorize
/v1/services/oauth/invalid/
/v1/services/oauth/errors/

should not be created, period.

romanchyla commented 9 years ago

it is not an extension (yet), it is a module - if you don't include the module in your services, then there are no routes; refactoring should come, we can speak with Lars, who comes next week

in my opinion, the right solution is to include services in api application, but we spoke about that already

vsudilov commented 9 years ago

Alternatively, we could treat solr as another microservice.

romanchyla commented 9 years ago

if you move out everything out of api, you can as well just move api into servcies - it will be the same thing

vsudilov commented 9 years ago

Have more of a handle on the issue now, closed.