search

adsabs / adsws

ADS web services
Other
2 stars 15 forks source link

verification time limit and log messages #85

Closed jonnybazookatone closed 8 years ago

jonnybazookatone commented 8 years ago

It is becoming more apparent that some users don't click the verification link within the 2 hour time frame. It is also a little difficult to entirely troubleshoot, as the log message for stale deletions does not include any user names. I'd suggest the following changes:

  1. Increase the time limit to verify the link
  2. Increase the verbosity of the deleted stale users (3. We could also e-mail people before/after their account is deleted due to not verifying)
aaccomazzi commented 8 years ago

What is the reason behind the 2 hours? Any problem with going to a full 24 hours? Also we should make this limit more prominent in the email message and feedback from submission.

jonnybazookatone commented 8 years ago

Don't know the reason for 2 hours, it was probably arbitrary as he didn't foresee someone not verifying the link after pressing sign up.

Sure 24 hours, I think it doesn't matter as long as they're informed in the sign-up e-mail that it'll be deleted after X hours.

jonnybazookatone commented 8 years ago

I guess it's not technically '2 hours', as the script is just run every two hours: https://github.com/adsabs/mission-control/blob/master/mc/templates/docker/cron/adsws/cronjob.sh#L3

and so for some people it could be 3 hours 59 minutes and 59 seconds :stuck_out_tongue:.

jonnybazookatone commented 8 years ago

+5 November +3 December

aaccomazzi commented 8 years ago

Ok, I vote for running the script daily and switch to a "24 hours" mode.

jonnybazookatone commented 8 years ago

v1.0.2