Closed jonnybazookatone closed 8 years ago
What is the reason behind the 2 hours? Any problem with going to a full 24 hours? Also we should make this limit more prominent in the email message and feedback from submission.
Don't know the reason for 2 hours, it was probably arbitrary as he didn't foresee someone not verifying the link after pressing sign up.
Sure 24 hours, I think it doesn't matter as long as they're informed in the sign-up e-mail that it'll be deleted after X hours.
I guess it's not technically '2 hours', as the script is just run every two hours: https://github.com/adsabs/mission-control/blob/master/mc/templates/docker/cron/adsws/cronjob.sh#L3
and so for some people it could be 3 hours 59 minutes and 59 seconds :stuck_out_tongue:.
+5 November +3 December
Ok, I vote for running the script daily and switch to a "24 hours" mode.
v1.0.2
It is becoming more apparent that some users don't click the verification link within the 2 hour time frame. It is also a little difficult to entirely troubleshoot, as the log message for stale deletions does not include any user names. I'd suggest the following changes: