adsabs / adsws

ADS web services
Other
2 stars 15 forks source link

Forwarding content-type served from the service rather than overriden by the API #89

Closed jonnybazookatone closed 8 years ago

jonnybazookatone commented 8 years ago

On a few occasions I've had the API completely ignore some of my headers returned from one service or another. In most cases this can be ignored. However, recently I'm trying to return a zip file from a service using flask.send_file, along with header information about the filename, 'Content-Disposition'. By ignoring the headers, the API also tried to decode the information, causing the zip file returned to be fairly garbage.

To alleviate this problem, I plan to return the headers from the service to the API, and from the API to the user at this line;

https://github.com/adsabs/adsws/blob/master/adsws/api/discoverer/views.py#L49

Should check that nothing important is going to be sent back by accident, such as the X-Adsws-User-ID, and any tokens.