search

adsabs / bumblebee

🐝 Clever face for ADS
https://ui.adsabs.harvard.edu
GNU General Public License v2.0
38 stars 21 forks source link

Download CSV data #2175

Closed shinyichen closed 3 years ago

shinyichen commented 3 years ago

For each metrics and histogram, provided download button to download corresponding CSV data. Screen Shot 2021-06-21 at 3 30 45 PM Screen Shot 2021-06-21 at 3 31 29 PM

shinyichen commented 3 years ago

It's been updated as suggested.

Instead of using <i> tags with a listener, can we switch to a <button> with the icon inside

Something like this:

<button class="btn btn-link download">
  <i class="fa-download ..." aria-hidden="true"></i>
  <span class="sr-only">download data</span>
</button>

which would have better accessibility

shinyichen commented 3 years ago

@thostetler Now it's ready for review