search

adsabs / tugboat

Pulling query parameters from ADS Classic to ADS BBB
0 stars 6 forks source link

app.py should only register name of the endpoints, not the prefix/service name #31

Open romanchyla opened 6 years ago

romanchyla commented 6 years ago

https://github.com/adsabs/tugboat/blob/master/tugboat/app.py#L26

app_register('/adsabs'... instead of app_register('/tugboat/adsabs'.....

golnazads commented 6 years ago

taylor [9:59 AM] so having /tugboat at the beginning of the url means one route can be used to get the traffic to tugboat otherwise each one of those paths will need an ingress rule to get them to tugboat

romanchyla commented 6 years ago

'tugboat/adsabs' is internal flask thing, if a webserver running the service only accepts requests at '/tugboat/adsabs'

This bears no influence for ingress controller. Our UI and API are routed by the ingress controller and none of the services have /v1 hardcoded in their url paths either. Tugboat should be no different.

So, tugboat service should run 'adsabs' endpoint and controller should route all request starting with /tugboat to it