search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.54k stars 676 forks source link

add testnet param for ws #349

Closed guotie closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #349 (bf14bfd) into master (09e883c) will decrease coverage by 0.12%. The diff coverage is 81.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   72.78%   72.66%   -0.13%     
==========================================
  Files          62       62              
  Lines        5868     5878      +10     
==========================================
  Hits         4271     4271              
- Misses       1181     1189       +8     
- Partials      416      418       +2
Impacted Files Coverage Δ
v2/futures/websocket_service.go 70.05% <81.53%> (-1.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09e883c...bf14bfd. Read the comment docs.

adshao commented 2 years ago

It's no a good idea to set testnet flag in parameters, we have a global var UseTestnet for it. Furthermore, it's better to use client for websocket services just like REST API.