search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.49k stars 661 forks source link

feat: add trade ID field to order fills #358

Closed sonirico closed 2 years ago

sonirico commented 2 years ago

As per binance docs (and tested empirically) fills have a field tradeId which is very useful to perform cross-matching in between the websocket feed and the standar API calls.

codecov[bot] commented 2 years ago

Codecov Report

Merging #358 (9db19b9) into master (ccf8ecf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files          63       63           
  Lines        5936     5936           
=======================================
  Hits         4297     4297           
  Misses       1214     1214           
  Partials      425      425
Impacted Files Coverage Δ
v2/order_service.go 75.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ccf8ecf...9db19b9. Read the comment docs.