search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.49k stars 661 forks source link

fix: unlockConfirm is a number not string #368

Closed c9s closed 2 years ago

adshao commented 2 years ago

Hi @c9s , could you please fix the Travis CI issue?

c9s commented 2 years ago

done, fixed the formatting issue.

gaga5lala commented 2 years ago

@c9s There's also a failed testing about the type https://app.travis-ci.com/github/adshao/go-binance/builds/250101951

...
vet: ./deposit_service_test.go:82:18: cannot convert "12/12" (untyped string constant) to int64
The command "go vet ./..." failed and exited with 2 during .

Seems like string is the correct type of deposit API (GET /sapi/v1/capital/deposit/hisrec (HMAC SHA256)). Please correct me if I misunderstood.

image

https://binance-docs.github.io/apidocs/spot/cn/#user_data-6

image https://binance-docs.github.io/apidocs/spot/cn/#user_data

c9s commented 2 years ago

Don't have time to fix this, so I am closing this PR