search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.54k stars 676 forks source link

Fix Unmarshal error on ListDeposits API response #381

Closed muzykantov closed 2 years ago

muzykantov commented 2 years ago

It is written in the documentation that the field is string, but in fact it returns int, which causes an error.

However, elsewhere in the documentation the field is already an integer.

"unLockConfirm": 0, // confirmation number for balance unlock

codecov[bot] commented 2 years ago

Codecov Report

Merging #381 (07698ae) into master (87c1345) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   70.80%   70.80%           
=======================================
  Files          66       66           
  Lines        6149     6149           
=======================================
  Hits         4354     4354           
  Misses       1353     1353           
  Partials      442      442
Impacted Files Coverage Δ
v2/deposit_service.go 87.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87c1345...07698ae. Read the comment docs.