adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 663 forks source link

Fixed missing quoteQty from recent and historical trades. #387

Closed GeorgeGkinis closed 2 years ago

GeorgeGkinis commented 2 years ago

Fixes Missing quoteQty on Trade struct #382 issue

GeorgeGkinis commented 2 years ago

@adshao Did I miss anything?

codecov[bot] commented 2 years ago

Codecov Report

Merging #387 (40f6656) into master (7742592) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   70.38%   70.38%           
=======================================
  Files          67       67           
  Lines        6241     6241           
=======================================
  Hits         4393     4393           
  Misses       1393     1393           
  Partials      455      455           
Impacted Files Coverage Δ
v2/trade_service.go 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7742592...40f6656. Read the comment docs.