Combined agg trade and book ticker

[basnijholt]

Reopening https://github.com/adshao/go-binance/pull/214

[adshao]

hi @basnijholt , could you please fix the vet error: https://app.travis-ci.com/github/adshao/go-binance/builds/253726661

[basnijholt]

@adshao, I have to admit I do not understand why this error occurs. Can you give me any suggestions?

[vinifrancosilva]

@adshao, I have to admit I do not understand why this error occurs. Can you give me any suggestions?

Seems like the func WsCombinedAggTradeServe was already implemented in line 369.

Push only the code for the combined bookticker.

I want to use it btw lol

[adshao]

@adshao, I have to admit I do not understand why this error occurs. Can you give me any suggestions?

It seems you should delete L419:L443

[vinifrancosilva]

Can you guys point me to some resource so I can learn how to contribute?

I don't know how to make a pull request or how things are handled. I only worked alone with git and used github as a central storage for my code.

I clone it in my in my machine, create a branch, work on it and push to origin?

[adshao]

Can you guys point me to some resource so I can learn how to contribute?

I don't know how to make a pull request or how things are handled. I only worked alone with git and used github as a central storage for my code.

I clone it in my in my machine, create a branch, work on it and push to origin?

Please kindly refer to this article to create a pull request from your forked repo: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

[basnijholt]

I have removed the duplicate function now, thanks for the help!

[vinifrancosilva]

Can you guys point me to some resource so I can learn how to contribute? I don't know how to make a pull request or how things are handled. I only worked alone with git and used github as a central storage for my code. I clone it in my in my machine, create a branch, work on it and push to origin?

Please kindly refer to this article to create a pull request from your forked repo: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

Thank you! Gonna undertand about the fork and if @basnijholt is away from this project, I will make the pull request.

[codecov[bot]]

Codecov Report

Merging #395 (3d59298) into master (f3bd66e) will decrease coverage by 0.22%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   70.25%   70.03%   -0.23%     
==========================================
  Files          75       76       +1     
  Lines        6992     7154     +162     
==========================================
+ Hits         4912     5010      +98     
- Misses       1568     1612      +44     
- Partials      512      532      +20     

Impacted Files	Coverage Δ
v2/websocket_service.go	74.79% <0.00%> (-2.92%)	:arrow_down:
v2/asset_detail_service.go	50.98% <0.00%> (-7.09%)	:arrow_down:
v2/deposit_service.go	81.15% <0.00%> (-6.35%)	:arrow_down:
v2/rate_limit_service.go	69.23% <0.00%> (ø)
v2/futures/order_service.go	59.45% <0.00%> (+0.20%)	:arrow_up:
v2/futures/client.go	76.21% <0.00%> (+0.23%)	:arrow_up:
v2/client.go	81.73% <0.00%> (+0.44%)	:arrow_up:
v2/subaccount_service.go	33.12% <0.00%> (+33.12%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[basnijholt]

Should be fixed now! :)

[adshao]

Should be fixed now! :)

thanks so much @basnijholt