search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 663 forks source link

implement mark price klines #402

Closed evzpav closed 1 year ago

evzpav commented 1 year ago

Hi @adshao,

I have implemented MarkPriceKlinesService according to: https://binance-docs.github.io/apidocs/futures/en/#mark-price-kline-candlestick-data

Thanks!

adshao commented 1 year ago

hi @evzpav , could you please rebase master branch and fix the gofmt error?

evzpav commented 1 year ago

hi @evzpav , could you please rebase master branch and fix the gofmt error?

changes done @adshao

codecov[bot] commented 1 year ago

Codecov Report

Merging #402 (cad8d92) into master (0ded954) will increase coverage by 0.11%. The diff coverage is 86.00%.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   70.22%   70.34%   +0.11%     
==========================================
  Files          70       71       +1     
  Lines        6644     6694      +50     
==========================================
+ Hits         4666     4709      +43     
- Misses       1488     1492       +4     
- Partials      490      493       +3
Impacted Files Coverage Δ
v2/futures/mark_price_kline_service.go 85.41% <85.41%> (ø)
v2/futures/client.go 76.50% <100.00%> (+0.23%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more