search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 663 forks source link

Fix fapi commission_rate_service (/fapi/v1/commissionRate) no signature param error #431

Closed kevinyang0127 closed 1 year ago

kevinyang0127 commented 1 year ago

Found that this api needs a signature and the response is not an array ref: https://binance-docs.github.io/apidocs/futures/en/#user-commission-rate-user_data

codecov[bot] commented 1 year ago

Codecov Report

Merging #431 (6de4383) into master (c1467dc) will increase coverage by 0.00%. The diff coverage is 60.00%.

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   70.03%   70.03%           
=======================================
  Files          76       76           
  Lines        7154     7155    +1     
=======================================
+ Hits         5010     5011    +1     
  Misses       1612     1612           
  Partials      532      532
Impacted Files Coverage Δ
v2/futures/commission_rate_service.go 77.77% <60.00%> (+1.30%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

kevinyang0127 commented 1 year ago

Hi @adshao , please help review this PR Thanks!

adshao commented 1 year ago

@kevinyang0127 thank you for the work!