search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 663 forks source link

support setting WebSocket Base URL #434

Open asamere opened 1 year ago

asamere commented 1 year ago

Would be better to create an instance to manage the websocket interactions as is done for the rest client. this is gets it done on my end.

codecov[bot] commented 1 year ago

Codecov Report

Merging #434 (ec20b7a) into master (c028fe5) will increase coverage by 0.04%. The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   69.91%   69.96%   +0.04%     
==========================================
  Files          76       76              
  Lines        7167     7171       +4     
==========================================
+ Hits         5011     5017       +6     
+ Misses       1624     1623       -1     
+ Partials      532      531       -1
Impacted Files Coverage Δ
v2/websocket_service.go 75.59% <87.50%> (+0.79%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

adshao commented 1 year ago

Yes, websocket service should be done in the a client instance. Would you like to create a pull request for this improvement?