adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 663 forks source link

binance.WsOrderUpdate.IsInOrderBook: ReadBool: expect t or f, but found 1 #449

Closed f0o closed 1 year ago

f0o commented 1 year ago

This started to happen very recently without any chances to the code. Did Binance silently update their APIs?

Full Error:

WS Error binance.WsOrderUpdate.IsInOrderBook: ReadBool: expect t or f, but found 1, error found in #10 byte of ...|000","W":16720467085|..., bigger context ...|.00000000","Y":"0.00000000","Q":"0.00000000","W":1672046708526,"V":"NONE"}|...
f0o commented 1 year ago

It seems that although w is specified as bool in https://binance-docs.github.io/apidocs/spot/en/#payload-order-update it might not always be transmitted?

I wonder if this error could be suppressed by omitempty

f0o commented 1 year ago

Actually this seems to be fixed in https://github.com/adshao/go-binance/pull/442 but this is not yet released...

adshao commented 1 year ago

Actually this seems to be fixed in #442 but this is not yet released...

please try v2.4.0

f0o commented 1 year ago

v2.4.0 fixed it