search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 663 forks source link

feat(/fapi/v1/userTrades): Add support for `orderId` param #478

Closed rtunazzz closed 1 year ago

rtunazzz commented 1 year ago

Adds support for the orderId param on the /fapi/v1/userTrades endpoint

📝 https://binance-docs.github.io/apidocs/futures/en/#account-trade-list-user_data

rtunazzz commented 1 year ago

@adshao Would appreciate if you could have a look, thanks!

adshao commented 1 year ago

@adshao Would appreciate if you could have a look, thanks!

Sorry for the late review, it's better to update the unit test as well.

rtunazzz commented 1 year ago

@adshao Would appreciate if you could have a look, thanks!

Sorry for the late review, it's better to update the unit test as well.

No worries, thanks for taking the time.

I'll remember it for the next time 😉