adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 663 forks source link

push new tag #484

Closed Sagleft closed 1 year ago

Sagleft commented 1 year ago

in the library, as well as in the API, there have been changes with the min notional filter. it is necessary to push new tag of the new version of the library, otherwise I do not understand how to connect it with these updates.

I tried to connect from master on a particular commit like this:

go get github.com/adshao/go-binance@57ba9f3022a3e06b46f78f0430ce15c4848b2a36
go: downloading github.com/adshao/go-binance v0.0.0-20230422133532-57ba9f3022a3
go: added github.com/adshao/go-binance v0.0.0-20230422133532-57ba9f3022a3

But then in go.mod I get:

...
github.com/adshao/go-binance v0.0.0-20230422133532-57ba9f3022a3 // indirect
...

which prevents me from importing the library in the code like this:

...
import (
    "context"
    "errors"
    "fmt"
    "strconv"
    "strings"
    "time"

    "github.com/adshao/go-binance/v2" // problem here: no required module provides package github.com/adshao/go-binance/v2
...
adshao commented 1 year ago

in the library, as well as in the API, there have been changes with the min notional filter. it is necessary to push new tag of the new version of the library, otherwise I do not understand how to connect it with these updates.

I tried to connect from master on a particular commit like this:

go get github.com/adshao/go-binance@57ba9f3022a3e06b46f78f0430ce15c4848b2a36
go: downloading github.com/adshao/go-binance v0.0.0-20230422133532-57ba9f3022a3
go: added github.com/adshao/go-binance v0.0.0-20230422133532-57ba9f3022a3

But then in go.mod I get:

...
github.com/adshao/go-binance v0.0.0-20230422133532-57ba9f3022a3 // indirect
...

which prevents me from importing the library in the code like this:

...
import (
  "context"
  "errors"
  "fmt"
  "strconv"
  "strings"
  "time"

  "github.com/adshao/go-binance/v2" // problem here: no required module provides package github.com/adshao/go-binance/v2
...

thanks @Sagleft , I just pushed a new tag v2.4.2, please test with this tag and let me know if there is any problem.

Sagleft commented 1 year ago

Thank you!