search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.54k stars 676 forks source link

changed bool types to string in reduceOnly, closePosition, priceProtect. #506

Closed size12 closed 4 months ago

size12 commented 1 year ago

There are should be STRING types in this fields.

image

BOOL type is still working in single order requests, but not is batch ones.

size12 commented 7 months ago

@adshao please check🙂

adshao commented 7 months ago

Hi @size12 , could you please add unit tests for this change?

maggch97 commented 4 months ago

This fix works in my project. Before this fix, I always got error when using BatchOrder [ code=-1102, msg=Mandatory parameter 'reduceOnly' was not sent, was empty/null, or malformed. code=-1102, msg=Mandatory parameter 'reduceOnly' was not sent, was empty/null, or malformed.]}

size12 commented 4 months ago

@adshao hi, this problem still exists, so please review my PR :)