search

adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 662 forks source link

update WsUserDataEvent struct #542

Closed XanderShum closed 3 months ago

XanderShum commented 5 months ago

Update the WsUserDataEvent struct according to the latest version of Binance documentation and solve the current case sensitivity problem.

This update has to make a few changes that break compatibility. Currently, only the e and E fields are common to all events. There is a problem that fields with the same name have different meanings and types in different events.

For example, the field "u" is the last update timestamp of the account in the outboundAccountPosition event, but it is the Trade Group Id in the executionReport event. Field "a" represents the asset in the outboundAccountPosition and balanceUpdate events and is of type string, but represents the Allocation ID in the executionReport event and is of type int.

In view of this, I have moved the fields "T" and "u" out of the shared fields to avoid possible bugs in the future.

XanderShum commented 5 months ago

Hi, @adshao Please review this change.

adshao commented 4 months ago

Hi @XanderShum , sorry for the late review. Could you please add more unit tests for the code changes?

XanderShum commented 4 months ago

Hi, @adshao I have updated the unit tests, please review this change.