adshao / go-binance

A Go SDK for Binance API
MIT License
1.48k stars 662 forks source link

Support for ed25519 secret/signing #559

Closed matiboy closed 1 week ago

matiboy commented 1 month ago

Hi,

Is ed25519 secret supported? Or only HMAC? (seems to be only HMAC)

Thanks!

xyq-c-cpp commented 1 week ago

yeah, it only supports HMAC. it is great if you could open a PR to push ed25519 secret supported. @matiboy

f0o commented 1 week ago

Considering @xyq-c-cpp closed the original https://github.com/adshao/go-binance/issues/459 issue regarding this without any sensible comment I assume that there is no interest in supporting this.

If you hit Auth issues you will have to disable the Default Security Controls unfortunately.

Or switch lib.

xyq-c-cpp commented 1 week ago

thanks for your concern, it's implement in last PR.