search

adshares / ads

ADS Blockchain
Other
21 stars 4 forks source link

field msg_id in transactions should be renamed #159

Open PawelPodkalicki opened 6 years ago

PawelPodkalicki commented 6 years ago

Most of transactions (all except empty and connection) has msg_id field. According to ads source code

const char* const MSGID = "msg_id";
ptree.put(TAG::MSGID, m_data.info.namsid);
uint32_t namsid{0};             ///< user message id

Field msg_id seems to be number of transaction sent from account (or node?). Field name is misleading, becuase it is similar tomessage_id, which has different meaning and format. Please, consider change.

Also, please review node_msg_id.

const char* const NODE_MSGID = "node_msg_id";
ptree.put(TAG::NODE_MSGID, m_data.info.node_msgid);
PawelPodkalicki commented 6 years ago

The issue was originally posted on ads-operator page: https://github.com/adshares/ads-operator/issues/55