adshayanB / jobMaps

3 stars 0 forks source link

Sort date #115

Closed adshayanB closed 3 years ago

adshayanB commented 3 years ago

image

adshayanB commented 3 years ago

This handles all the available date fields

adshayanB commented 3 years ago

Hey, small concern - I could be misunderstanding it but I think it looks like all of them are using req.body.order to decide if its ascending / descending. I'm just wonderig what could happen if a user wants to sort company in ascending order and at the same time have date applied in descending as a secondary sorting field (just an example). Then wouldn't we run into an issue bc its all using the same indicator, req.body.order? Or maybe im misunderstanding IDK lmklmk

Discussed in a meeting.

adshayanB commented 3 years ago

Merging as comments were resolved.