search

adshayanB / jobMaps

3 stars 0 forks source link

Style filters #139

Closed Jaishreebala closed 3 years ago

Jaishreebala commented 3 years ago

Styled filters - the data for company / job title is dummy info, will be updated when integrated with backend.

Screen Shot 2021-07-26 at 11 56 22 PM

Each section is scrollable if it goes past a certain height, feel free to clone / mess around w it and lmk if any changes

Jaishreebala commented 3 years ago

Just a few nits, could we add some padding between the filter and the container that displays the apps?

As well as instead of scrolling could we have a see more, or see all for them to see all options (if its too long)

image

is this padding better? @adshayanB

adshayanB commented 3 years ago

Just a few nits, could we add some padding between the filter and the container that displays the apps? As well as instead of scrolling could we have a see more, or see all for them to see all options (if its too long)

image

is this padding better? @adshayanB

Yup that’s exactly what I wanted!

Jaishreebala commented 3 years ago

Yup that’s exactly what I wanted!

Okay perf, now for the "see more" thing, I just had a few concerns - so if we had a "see more" button then on clicking it would show all these jobs. it looks iffy imo bc its just really song, and if a user wants to see the company info filters its just less accessible? Bc we would assume there's at least 50 ish jobs that a user has applied to (minimum) and if they applied to 50 diff companies then there's 50 checkboxes, so an overall scroll seems to be iffy to me.

Screen Shot 2021-07-27 at 1 33 15 PM image

something like this. so I feel iffy about it, are you sure "see more" is a good idea? bc I can implement and we can feel it out, these are just my concerns. @adshayanB

adshayanB commented 3 years ago

Looks good to me now. We were able to clear the other stuff during our discussion. Will approve :)