adsr / irslackd

self-hosted IRC gateway to Slack
Apache License 2.0
162 stars 21 forks source link

Send RPL_ISUPPORT (005) #119

Open AeliusSaionji opened 1 year ago

AeliusSaionji commented 1 year ago

Hello, I encountered an issue with the android irc client goguma, which adheres to what the developer refers to as the "defacto standard RFC": https://modern.ircdocs.horse/#connection-registration

Upon successful completion of the registration process, the server MUST send, in this order, the RPL_WELCOME (001), RPL_YOURHOST (002), RPL_CREATED (003), RPL_MYINFO (004), and at least one RPL_ISUPPORT (005) numeric to the client.

At least one 005 is required, and none are sent https://github.com/adsr/irslackd/blob/3e92616b8a2a41d3d193317dd98a2c5bae2a87d9/lib/irslackd.js#L508-L509

If the server reply is missing CHANTYPES then, by the protocol, the client should expect that the server does not support channels.

And so, that's what happens in Goguma; all messages coming from ircd are received as private messages from each user, because it doesn't think the server supports channels.

I have no business telling irslackd to use this "defacto standard" over the formal RFC, I'm just a user caught in the middle of these two projects (irslackd and goguma).

Emersion is taking the stance that this is not goguma's bug, so I suppose it's up to irslackd how to proceed.

Thanks

AeliusSaionji commented 1 year ago

referencing PR #120