adsr / mle

flexible terminal-based text editor (C)
Apache License 2.0
827 stars 53 forks source link

Add 1.7.2 to Debian unstable #79

Closed adsr closed 1 year ago

adsr commented 1 year ago

Branch https://github.com/adsr/mle/tree/debian_1_7_2 is ready. Bump @cdluminate.

I uploaded to ftp https://github.com/adsr/mle/issues/69#issuecomment-1562113161

cdluminate commented 1 year ago

Two issues you might want to take a look at the next revision:

N:
W: mle: debian-changelog-has-wrong-day-of-week 2023-05-24 was a Wednesday [usr/share/doc/mle/changelog.Debian.gz:1]
N: 
N:   The date in the changelog entry is not consistent with the actual day of that week. Either the date is wrong or the day of week is wrong.
N:   
N:   To avoid problems like this, consider using a tool like dch(1) or date(1) to generate the date. Example:
N:   
N:     $ date -R -ud '2013-11-05 23:59:59'
N:     Tue, 05 Nov 2013 23:59:59 +0000
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: debian/changelog
N:   Renamed from: debian-changelog-has-wrong-weekday
N: 
N:
I: mle: hardening-no-fortify-functions [usr/bin/mle]
N: 
N:   This package provides an ELF binary that lacks the use of fortified libc functions. Either there are no potentially unfortified functions called by any routines, all
N:   unfortified calls have already been fully validated at compile-time, or the package was not built with the default Debian compiler flags defined by dpkg-buildflags. If
N:   built using dpkg-buildflags directly, be sure to import CPPFLAGS.
N:   
N:   NB: Due to false-positives, Lintian ignores some unprotected functions (e.g. memcpy).
N: 
N:   Please refer to https://wiki.debian.org/Hardening and Bug#673112 for details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/hardening
N: 
cdluminate commented 1 year ago

Uploaded to ftp-master. I was just too busy to deal with Debian stuff a while ago. The mentors upload is not required if you are only waiting for me to sponsor the upload. That said, if I'm too slow or busy to respond, the mentors upload will be helpful. I think you have seen the RFS guide. But you don't need it now.

cdluminate commented 1 year ago

This is what you need to fix hardening.

diff --git a/debian/patches/fix b/debian/patches/fix
new file mode 100644
index 0000000..86fc0db
--- /dev/null
+++ b/debian/patches/fix
@@ -0,0 +1,12 @@
+Index: mle/Makefile
+===================================================================
+--- mle.orig/Makefile
++++ mle/Makefile
+@@ -1,6 +1,6 @@
+ prefix?=/usr/local
+ 
+-mle_cflags:=-std=c99 -Wall -Wextra -pedantic -Wno-pointer-arith -Wno-unused-result -Wno-unused-parameter -g -O0 -D_GNU_SOURCE -DPCRE2_CODE_UNIT_WIDTH=8 -I. $(CFLAGS)
++mle_cflags:=-std=c99 -Wall -Wextra -pedantic -Wno-pointer-arith -Wno-unused-result -Wno-unused-parameter -g -O0 -D_GNU_SOURCE -DPCRE2_CODE_UNIT_WIDTH=8 -I. $(CFLAGS) $(CPPFLAGS)
+ mle_ldflags:=$(LDFLAGS)
+ mle_dynamic_libs:=-lpcre2-8 -llua5.4
+ mle_static_libs:=vendor/pcre2/.libs/libpcre2-8.a vendor/lua/liblua5.4.a
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..a609090
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+fix
diff --git a/debian/rules b/debian/rules
index d704428..5d31057 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,5 +1,5 @@
 #!/usr/bin/make -f
-
+include /usr/share/dpkg/buildflags.mk
 export DEB_BUILD_MAINT_OPTIONS=hardening=+all

 %:
cdluminate commented 1 year ago

https://github.com/adsr/mle/pull/80

adsr commented 1 year ago

Thank you @cdluminate