search

adswerve / universal-analytics-python

Universal Analytics Python module
BSD 3-Clause "New" or "Revised" License
107 stars 41 forks source link

Add Python3 compatibility #13

Open goanpeca opened 8 years ago

goanpeca commented 8 years ago

So I needed to track some analytics and this library seemed to work fine except the python3 issue.

I added python3 compatibility using six, fixed the tests to run on py3 as well and fixed the code to be pep8 compliant.

I am using this in my fork now, but left this here in case the project is still supported.

Cheers

goanpeca commented 8 years ago

@samba any chance of getting this merged?

samba commented 8 years ago

@goanpeca Sorry for the late follow up. This project is maintained by Analytics Pros, my former employer. I've contacted them to consider merging these changes, as they retain ownership and privileges to accept merges on this repository.

Thank you for this contribution, and remedying my lack of PEP-8 in the original authorship :) By visual inspection I believe the changes are sound, so I'll encourage Analytics Pros to merge these at their earliest opportunity.

goanpeca commented 8 years ago

@samba, :+1:

goanpeca commented 8 years ago

@LukaData now this has conflicts, should I fix or just close the PR?

lukaszbanasiak commented 8 years ago

@goanpeca can you provide commit to this PR with resolved conflict?