Add Python 3 compatibility (updated)

asavoy commented 7 years ago

This pull request builds from the work by goanpeca in https://github.com/analytics-pros/universal-analytics-python/pull/13.

In addition to the Python 3 compatibility and PEP8 code style fixes in the original branch, these have also been done:

Rebased the branch on top of latest master, resolved conflicts
Inspected code to ensure latest master changes are present
Spot-fixed a case of Python 3 incompatibility
Ran test/test_everything.py successfully on Python 2 and Python 3
Ran in a Python 3 virtualenv with a live GA account and confirmed that data sent appears in GA
Reverted one change to handling VERSION in setup.py, so that it behaves as it does in master

What hasn't been done:

I haven't done any deep review of the Python 3 changes. There are some issues that would warrant a closer look, but don't seem to cause any problems in testing:
- Some instances of str still remain when they probably should be six.text_type
- Some commented out code
I haven't done any manual testing in Python 2 to confirm it works with a live GA account.

I think this is at least at a working point that is worth checking in for a maintainer's feedback, if at least to gauge interest in getting this merged in.

BoboTiG commented 6 years ago

Any news from the owner?

olymk2 commented 6 years ago

can this be merged / can another dev take ownership if it no longer maintained ?

adswerve / universal-analytics-python

Add Python 3 compatibility (updated) #19