search

adtools / amigaos-cross-toolchain

AmigaOS cross compiler for Linux / MacOSX / Windows
184 stars 48 forks source link

Please add "__amigaos3__" define to GCC patchset #62

Open jens-maus opened 7 years ago

jens-maus commented 7 years ago

For convenience reasons it would be great if you could add a default __amigaos3__ define to the GCC patchset. AmigaOS3 has __amigaos4__ and MorphOS has __MORPHOS__ defined by default. To better distinguish between different OS compilations it would be great to have __amigaos3__ defined per default for the GCC 2.95.3 patchset you are using for your cross toolchain.

cahirwpz commented 7 years ago

Well... one can compile binaries for AmigaOS 1.3 with the toolchain. IMO availability of __amigaos3__ definition would be potentialy misleading in such case.

Is there any reason why you can't use one of default preprocessor definitions listed in amigaos.h ? I could add __amigaos__ if that's really necessary.

jens-maus commented 7 years ago

First of all, nobody wants and requires AmigaOS 1.3 anymore ;)

The problem with the standard amigaos, amiga or AMIGA defines is that they are also present in other compiler suites like GCC for OS4 and MorphOS. So to distinguish between GCC for OS4 and MorphOS one can perfectly use __amigaos4__ and __MORPHOS__, but to actually find out if sources are compiled for legacy amigaos one always have to use complex preprocessor statements like

#if !defined(__amigaos4__) && !defined(__MORPHOS__) && !defined(__AROS__)

And this is quite inconvenient. Also please keep in mind that __amigaos3__ shouldn't be interpreted as just referring to compiling for AmigaOS 3.0 or 3.1, but rather means that the sources are compiled for legacy/classic AmigaOS versions. Checks to actually distinguish between AmigaOS 1.x, 2.x and 3.x should rather be done on runtime and not via preprocessor macros, IMHO.