search

adtools / amigaos-cross-toolchain

AmigaOS cross compiler for Linux / MacOSX / Windows
184 stars 48 forks source link

Fix toolchain-ppc #91

Closed csnover closed 6 years ago

csnover commented 6 years ago

toolchain-ppc has been broken for a while; this changeset gets it working again. There are some changes here that probably need to be applied to toolchain-m68k as well, like changing the ftp URLs to https for gnu.org since that service is being turned off, but I did not make these changes since I don’t have any use for a GCC2 compiler.

csnover commented 6 years ago

Actually, you can probably just ignore/close this and delete toolchain-ppc entirely since there is a much more up-to-date cross-compiler available at https://github.com/sba1/adtools.

cahirwpz commented 6 years ago

Thanks for the patch! I looked briefly through it and it looks ok, although my impression is that you modified much more that is necessary to fix ppc-amigaos build – that usually slows down the review.

I'd love to unify the way both toolchains are build and packaged. So I think it's still worth investing some time to update & fix toolchain-ppc script – therefore PRs are welcome.

Please note that I'll not accept a patch that breaks the build (red cross after your last commit). Sometimes failed builds are transient (due to download servers downtime) - if that's the case, then you should not worry.

cahirwpz commented 6 years ago

Please give me write access to your branch. Otherwise I'm unable to proceed with fixes that will make the PR eligible for merging with master branch.

cahirwpz commented 6 years ago

ppc-amigaos target was fixed in 66015fb1103a3690d09ab2aa540b868c896d8919, protocol for ftp.gnu.org switched to HTTPS in 1325e1dc8799a97c8bd29c7a38eb4552a8f94e90. Since the build procedure has moved to CircleCI, ppc-amigaos is built each time a commit is made to the repository.