search

adtzlr / trusspy

Nonlinear Truss Solver for Python
http://trusspy.readthedocs.io/
GNU General Public License v3.0
53 stars 11 forks source link

Simplify the code #37

Closed adtzlr closed 1 year ago

adtzlr commented 1 year ago

Remove unused lines of code (code which is commented out), remove to do's from docstrings, fix docstrings

closes #38

see also #17: Result was never used because the ResultHandler is based on Analysis. Hence, the unused Result is now removed.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 90.00% and project coverage change: +2.77 :tada:

Comparison is base (9a168e5) 86.40% compared to head (1c87558) 89.18%.

:exclamation: Current head 1c87558 differs from pull request most recent head c8c6030. Consider uploading reports for the commit c8c6030 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================== + Coverage 86.40% 89.18% +2.77% ========================================== Files 28 27 -1 Lines 1361 1313 -48 ========================================== - Hits 1176 1171 -5 + Misses 185 142 -43 ``` | [Impacted Files](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler) | Coverage Δ | | |---|---|---| | [src/trusspy/core/analysis.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvY29yZS9hbmFseXNpcy5weQ==) | `86.27% <ø> (ø)` | | | [src/trusspy/core/boundary.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvY29yZS9ib3VuZGFyeS5weQ==) | `80.00% <ø> (ø)` | | | [src/trusspy/core/element.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvY29yZS9lbGVtZW50LnB5) | `83.33% <ø> (ø)` | | | [src/trusspy/core/external\_force.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvY29yZS9leHRlcm5hbF9mb3JjZS5weQ==) | `100.00% <ø> (ø)` | | | [src/trusspy/core/node.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvY29yZS9ub2RlLnB5) | `100.00% <ø> (ø)` | | | [src/trusspy/elements/element\_definition.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvZWxlbWVudHMvZWxlbWVudF9kZWZpbml0aW9uLnB5) | `100.00% <ø> (ø)` | | | [src/trusspy/handlers/handler\_boundary.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvaGFuZGxlcnMvaGFuZGxlcl9ib3VuZGFyeS5weQ==) | `77.35% <ø> (ø)` | | | [src/trusspy/handlers/handler\_element.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvaGFuZGxlcnMvaGFuZGxlcl9lbGVtZW50LnB5) | `84.21% <ø> (+0.87%)` | :arrow_up: | | [src/trusspy/solvers/tpsolver.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvc29sdmVycy90cHNvbHZlci5weQ==) | `90.90% <ø> (ø)` | | | [src/trusspy/tools/helper\_functions2.py](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler#diff-c3JjL3RydXNzcHkvdG9vbHMvaGVscGVyX2Z1bmN0aW9uczIucHk=) | `86.25% <ø> (-0.20%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/adtzlr/trusspy/pull/37?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Andreas+Dutzler)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.