search

adulau / pdns-qof

Passive DNS Common Output Format
https://datatracker.ietf.org/doc/draft-dulaunoy-dnsop-passive-dns-cof/
36 stars 15 forks source link

Address Eliots initial comments #33

Closed wkumari closed 2 months ago

wkumari commented 2 months ago

These set of changes address Eliot's initial ISE comments.

adulau commented 2 months ago

Thanks a lot for the PR. The changes make a lot of sense. I republished the I-D as 13 https://datatracker.ietf.org/doc/draft-dulaunoy-dnsop-passive-dns-cof/ and if there is more reviews or update, I'll do a 14 after.

wkumari commented 2 months ago

I replied to Eliot with a summary of changes, and also linking to the new document / diff.

I also made the change suggested above — we actually said that the document describes the format used by four implementations, but had listed 5, so deleting one was easy :-)

W

On Fri, Aug 30, 2024 at 4:59 AM, Alexandre Dulaunoy < @.***> wrote:

Thanks a lot for the PR. The changes make a lot of sense. I republished the I-D as 13 https://datatracker.ietf.org/doc/ draft-dulaunoy-dnsop-passive-dns-cof/ and if there is more reviews or update, I'll do a 14 after.

— Reply to this email directly, view it on GitHub https://github.com/adulau/pdns-qof/pull/33#issuecomment-2320555644, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDG3XGWLFTINXVVAGIKNULZUAX6NAVCNFSM6AAAAABNGUVFUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGU2TKNRUGQ . You are receiving this because you were mentioned.Message ID: @.***>