gracefully handle tplink.login() failure

[blaskovicz]

If login fails to return a token, it throws the error: (node:3353) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'token' of undefined

Rather than the actual response error (for example, I didn't pass any params): { error_code: -20104, msg: 'Parameter doesn\'t exist' }

[ColinMcNeil]

Is it a bug to assume the developer is passing params?

[blaskovicz]

I would say throwing an error if the required function params aren't passed AND exposing the actual response error is preferred. I can put a pull request up once I've had more time to play with the library and see what else I like/have issues with.

[ColinMcNeil]

This repo hasn't been updated since April... https://github.com/adumont/tplink-cloud-api/pull/17 If you want to fork it, I would also like to PR this https://github.com/adumont/tplink-cloud-api/pull/14

[blaskovicz]

I also found this repo, https://github.com/plasticrake/tplink-smarthome-api/, which looks very active but doesn't support cloud interactions out of the box. Another option is to add cloud support there so we can merge these feature sets, since that repo is very active.

[ColinMcNeil]

That one is also much more than what I typically need it for, and also does not work with Webpack. (https://github.com/ColinMcNeil/TP-Link-WebApp) Otherwise I would've stopped subscribing to notifications here.

[blaskovicz]

Understood. I was using it as a reference since I noticed some other good features that are implemented there but missing here. For example, when I do a device list, I'd like to see those devices come back as instantiated device objects so I can directly action on them (eg: powerOn, etc).

I took a look at your code! I'm trying to build a similar thing (dashboard for turning things on/off) but on a garmin watch (eg: I did this for nest https://github.com/blaskovicz/garmin-nest-camera-control)

[blaskovicz]

@ColinMcNeil have you noticed issues with device list returning stale data from tplink's api? For example, I was able to easily turn my LB120 on/off but the status stays at 1 in the response.

[blaskovicz]

forked to https://github.com/blaskovicz/tplink-cloud-api and did 3 things:

• switched to yarn
• prettiered the code
• added a bunch of helpers and error checking

[ColinMcNeil]

Yes, the return data is unreliable. You can send another request on a delay and it might give better updates?

[blaskovicz]

@ColinMcNeil I sent a request this morning after about 6 hours and it still says the light is on. This is going to be a big issue for my app if the results are never updated. :/

I ran into a similar issue with Nest API, but the cache latency wasn't forever bad...

Any ideas?

[blaskovicz]

We can move that discussion over here: https://github.com/blaskovicz/tplink-cloud-api/issues/3

[blaskovicz]

Addressed in #19 .

still not sure what's going on with the device list status caching, @adumont have you run into that?

[blaskovicz]

I realized that asking for the system info of a device (system: { get_sysinfo: null }), will return the actual state ({light_state: { on_off: 0 }}), whereas getDeviceList perpetually returns { status: 1}

[blaskovicz]

added more functions for .powerOn and .powerOff for bulbs

[adumont]

Addressed in #19 by @blaskovicz (Thanks)